This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
Emit query log in quaint:query span, rather than in its parent #431
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelff
commented
Jan 27, 2023
| @@ -14,8 +14,16 @@ where | |||
| U: Future<Output = crate::Result<T>>, | |||
| { | |||
| let span = info_span!("quaint:query", "db.statement" = %query); | |||
There was a problem hiding this comment.
In the query engine binary and node API, This span is filtered-in by target , because it is user facing but doesn't have a user_facing attribute. Should we add the attribute to prevent this additional filtering based on the target?
I know, it's coupling quiant to engine needs. But isn't that already based on all the tracing features added to it?
miguelff
added a commit
to prisma/prisma-engines
that referenced
this pull request
Jan 27, 2023
|
Given the correct behavior of this patch, the simplicity of the change, and the lack of required reviewers for quaint, I will merge this on Monday, unless there's strong opposition --in a bias to action. |
miguelff
added a commit
to prisma/prisma-engines
that referenced
this pull request
Jan 27, 2023
miguelff
added a commit
to prisma/prisma-engines
that referenced
this pull request
Jan 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked in https://github.com/prisma/client-planning/issues/158
Addressed the problem expressed in https://github.com/prisma/client-planning/issues/158#issuecomment-1405530608
Before this change query log events where not attached to the
quaint:queryspan but its parent. This had implications on log capturing. mainly, thatBEGINiTX queries where not logged until its owner span (itx_runner) was not closed at the end of the transaction.